feat: [#334] Improve run command output with service URLs#337
Merged
josecelano merged 4 commits intomainfrom Feb 11, 2026
Merged
feat: [#334] Improve run command output with service URLs#337josecelano merged 4 commits intomainfrom
josecelano merged 4 commits intomainfrom
Conversation
Phase 1: Extract Shared View Components - Create shared view module for service URL rendering - Add CompactServiceUrlsView for compact service URL display - Add DnsHintView for TLS/HTTPS DNS configuration hints - Filter out localhost-only services (show only public URLs) - Include comprehensive unit tests for all views - All tests passing (15 tests)
- Load environment state after services start in RunCommandController - Display service URLs using CompactServiceUrlsView (only public services) - Show DNS hint for HTTPS services using DnsHintView - Add tip about using 'show' command for full details - Add From<RepositoryError> conversion for proper error handling - Reuse ServiceInfo extraction logic from show command pattern Phase 2 Complete: Enhanced run command output with service URLs
- Add Command Output section to run.md showing service URL display - Include examples for both HTTP and HTTPS/TLS environments - Show DNS configuration hint for TLS deployments - Update console-commands.md with new output format - Add tip about using 'show' command for full details All changes follow existing documentation structure and pass linters
- All phases complete: shared views, enhanced output, documentation - 15 unit tests passing for shared view components - All E2E tests pass and exercise new code paths - Documentation updated with output examples - All pre-commit checks passing - Implementation follows all architectural requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhances the
runcommand output to display service URLs immediately after services start, improving actionability by giving users direct access to their deployed services.Closes #334
Changes
Phase 1: Shared View Components ✅
src/presentation/views/commands/shared/service_urls/modulePhase 2: Enhanced Run Command Output ✅
RunCommandController::complete_workflow()to display service URLsdisplay_service_urls()method using shared viewsload_environment()method reusing show command patternFrom<RepositoryError>conversion for proper error handlingPhase 3: Documentation ✅
docs/user-guide/commands/run.mdwith new output examplesdocs/console-commands.mdwith new output formatSample Output
Run Command (New Feature - HTTPS/TLS Environment)
Show Command (Comparison - Full Details)
Architecture
src/presentation/views/commands/shared/service_urls/runandshowcommands (no duplication)Quality Assurance
Architecture Compliance
UserOutputmethods (noprintln!)ProgressReporter::result()Commits
feat: [#334] add shared service URL views- Phase 1: Shared view componentsfeat: [#334] display service URLs after run command completes- Phase 2: Enhanced outputdocs: [#334] update run command documentation with service URLs- Phase 3: Documentation (part 1)docs: [#334] mark implementation complete with all acceptance criteria- Phase 3: Documentation (part 2)Testing
Verified with manual E2E test:
configure lxd-local-https-examplerelease lxd-local-https-examplerun lxd-local-https-example✅ New output displayedshow lxd-local-https-example✅ Full details shownRationale
showoutput (omits SSH details, internal ports)showcommandThe
runcommand is the moment users want to use the services, so showing URLs immediately provides high value.